Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

e2e_windows Test Failure Fix for #4808 - #4868

Closed
Spacesai1or wants to merge 1 commit into
1.xfrom
wyatt/1.x/4808-e2e-windows-test-fix
Closed

e2e_windows Test Failure Fix for #4808#4868
Spacesai1or wants to merge 1 commit into
1.xfrom
wyatt/1.x/4808-e2e-windows-test-fix

Conversation

@Spacesai1or

Copy link
Copy Markdown
Contributor

Merge #4808 into a new branch, so that the e2e_windows test may have access to the Infura key

@Spacesai1or Spacesai1or added the 1.x 1.0 related issues label Mar 18, 2022
@Spacesai1or Spacesai1or self-assigned this Mar 18, 2022
@render

render Bot commented Mar 18, 2022

Copy link
Copy Markdown

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2003858233

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.497%

Totals Coverage Status
Change from base Build 2002669572: 0.0%
Covered Lines: 3238
Relevant Lines: 4102

💛 - Coveralls

@ghost

ghost commented Mar 18, 2022

Copy link
Copy Markdown

For testing purpose, you can also use the public key for infura endpoint which is being used for metamask as well

https://rpc.info/

https://mainnet.infura.io/v3/9aa3d95b3bc440fa88ea12eaa4456161

For websocket,

https://github.com/ethers-io/ethers.js/blob/50d712d6afc927aaee68b482157598554a45d403/packages/providers/src.ts/alchemy-provider.ts#L21

These two endpoint is open as default for ethers.js users

https://eth-mainnet.alchemyapi.io/v2/_gg7wSSi0KMBsdKnGVfHDueq6xMB9EkC

wss://eth-mainnet.alchemyapi.io/v2/_gg7wSSi0KMBsdKnGVfHDueq6xMB9EkC

One of the life hacks not to pay them though

@ghost

ghost commented Mar 18, 2022

Copy link
Copy Markdown

Opened PR to add hardcoded alchemy provider as a backup #4869

@luu-alex
luu-alex self-requested a review March 21, 2022 14:47
@avkos
avkos self-requested a review March 22, 2022 15:55
@Spacesai1or Spacesai1or added the Do Not Merge Not allowed to be merged label Mar 23, 2022
@Spacesai1or

Copy link
Copy Markdown
Contributor Author

At the request of @jdevcs, this was put on hold until we can either A. Deploy the xhr2-cookies-patched under the ChainSafe NPM org, or B. Find an alternative package that's already established and can accomplish the same missing functionality

@ghost

ghost commented Mar 24, 2022

Copy link
Copy Markdown

@spacesailor24 @jdevcs I think we have the consensus now, could you publish the library under the repo of @ChainSafe ?

@avkos
avkos removed their request for review April 20, 2022 14:03
@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions Bot added the Stale Has not received enough activity label Jun 20, 2022
@github-actions github-actions Bot closed this Jul 4, 2022
@Spacesai1or
Spacesai1or deleted the wyatt/1.x/4808-e2e-windows-test-fix branch August 4, 2022 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Do Not Merge Not allowed to be merged Stale Has not received enough activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants