This repository was archived by the owner on Mar 5, 2025. It is now read-only.
[Types] Fix typo in BlockHeader type - #5110
Closed
marcelltoth wants to merge 3 commits into
Closed
Conversation
jdevcs
suggested changes
Jun 9, 2022
jdevcs
left a comment
Contributor
There was a problem hiding this comment.
@marcelltoth Thanks for this PR. changelog update is also required under 1.7.5
Pull Request Test Coverage Report for Build 2544291381
💛 - Coveralls |
Contributor
|
Same changes PR as #5083 |
Contributor
|
As the PR #5083 with same change was created earlier, so I am closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a typo in the typings for
BlockHeader. As documented here blocks have atransactionsRootproperty, but the typings spelled it astransactionRoot. Of course that property does not exist and will result inundefinedvalues when using.Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary. N/Anpm run test:covand my test cases cover all the lines and branches of the added code. N/Anpm run buildwith success. N/A (Won't CI run these anyway though?)dist/web3.min.jsin a browser. N/ACHANGELOG.mdfile in the root folder. How do I do so exactly, without knowing the version number upfront?