Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Add createAccessList type (#5146) - #5204

Merged
jdevcs merged 2 commits into
1.xfrom
junaid/createaccesslisttypes
Jul 5, 2022
Merged

Add createAccessList type (#5146)#5204
jdevcs merged 2 commits into
1.xfrom
junaid/createaccesslisttypes

Conversation

@jdevcs

@jdevcs jdevcs commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Description

This PR is for CI checks of #5146

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@0xall @jdevcs
Add createAccessList type (#5146)
cdb4dc9 
* add createAccessList method type in web3.eth

* add optional error field in CreateAccessList result type

* update CHANGELOG.md

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@jdevcs jdevcs self-assigned this Jul 5, 2022
@render

render Bot commented Jul 5, 2022

Copy link
Copy Markdown

Your Render PR Server URL is https://web3-js-pr-5204.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb2269vs437h7vo6immg.

@coveralls

coveralls commented Jul 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2615891358

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.342%
Totals Coverage Status
Change from base Build 2615752940: 0.0%
Covered Lines: 3262
Relevant Lines: 4138
💛 - Coveralls

@jdevcs

jdevcs commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

The code changes in this PR are approved in #5146 , and all CI checks are passing in this PR, so merging.

@jdevcs
jdevcs merged commit 57b6dc4 into 1.x Jul 5, 2022
@jdevcs
jdevcs deleted the junaid/createaccesslisttypes branch July 5, 2022 11:56
@jdevcs jdevcs mentioned this pull request Jul 5, 2022
Merged
16 tasks
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jdevcs jdevcs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdevcs @coveralls @0xall