This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fixed unit tests & removed dead code for web3-providers-http (#5228) - #5264
Merged
Conversation
* Fixed unit tests & removed dead code for web3-providers-http * Use chai-as-promised to resolve or reject promise * Fixed bug that timeout option doesn't work properly
|
Your Render PR Server URL is https://web3-js-pr-5264.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbb8f2r0tnuvdk1hmc90. |
jdevcs
marked this pull request as ready for review
July 19, 2022 10:29
Pull Request Test Coverage Report for Build 2696970239
💛 - Coveralls |
Contributor
Author
|
All code changes in this PR are approved in #5228 and tests are passing so merging in 1.x |
14 tasks
This was referenced Oct 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for e2e win tests in CI of #5228
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.