Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

update node versions - #5354

Merged
luu-alex merged 11 commits into
1.xfrom
node-ver-draft
Aug 18, 2022
Merged

update node versions#5354
luu-alex merged 11 commits into
1.xfrom
node-ver-draft

Conversation

@luu-alex

@luu-alex luu-alex commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

#4888 Updating node version for builds and fixing mosaic tests that were failing due to node 12 version. Was running into issues trying to include more node versions with what seemed like random 1-2 test cases failing

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render

render Bot commented Aug 16, 2022

Copy link
Copy Markdown

@coveralls

coveralls commented Aug 16, 2022

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2878018154

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.255%

Totals Coverage Status
Change from base Build 2775256859: 0.0%
Covered Lines: 3402
Relevant Lines: 4432

💛 - Coveralls

@jdevcs jdevcs added the 1.x 1.0 related issues label Aug 17, 2022
@luu-alex
luu-alex marked this pull request as ready for review August 18, 2022 06:41
@jdevcs

jdevcs commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

LGTM, for :

Was running into issues trying to include more node versions with what seemed like random 1-2 test cases failing

wts are error logs?

@jdevcs

jdevcs commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

For
image
I updated 1.x repo branch rules., so with new commit push it will not be required.

@jdevcs jdevcs added the Future Release For future release. label Aug 18, 2022
@jdevcs

jdevcs commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Is this duplicate PR #5314 ? For current PR, also mention it in changelog. Thanks

@jdevcs jdevcs removed the Future Release For future release. label Aug 18, 2022
@nikoulai
nikoulai self-requested a review August 18, 2022 13:59
@luu-alex

Copy link
Copy Markdown
Contributor Author

@jdevcs when using node 14 and node 16 node-gyp has an error installing and mosaic has a test contract error. heres the CI

@luu-alex

Copy link
Copy Markdown
Contributor Author

@jdevcs yes is a duplicate, will close the other

This was referenced Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants