Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

docs: Fix example of tx usage - #5402

Merged
jdevcs merged 8 commits into
web3:1.xfrom
acolytec3:tx-usage
Sep 7, 2022
Merged

docs: Fix example of tx usage#5402
jdevcs merged 8 commits into
web3:1.xfrom
acolytec3:tx-usage

Conversation

@acolytec3

Copy link
Copy Markdown

Description

Fixes documentation of @ethereumjs/tx usage in the code example for eth_sendSignedTransaction

Type of change

  • I have made corresponding changes to the documentation.
  • I have updated the CHANGELOG.md file in the root folder.

Comment thread CHANGELOG.md Outdated
@jdevcs jdevcs added 1.x 1.0 related issues Documentation Relates to project wiki or documentation labels Aug 31, 2022
Comment thread CHANGELOG.md Outdated
@acolytec3

Copy link
Copy Markdown
Author

@avkos Done!

@avkos
avkos requested review from avkos and jdevcs September 6, 2022 16:32
Comment thread docs/web3-eth.rst
Comment thread CHANGELOG.md
Comment on lines -7 to -36
<!-- EXAMPLE

## [1.0.0]

### Added

- I've added feature XY (#1000)

### Changed

- I've cleaned up XY (#1000)

### Deprecated

- I've deprecated XY (#1000)

### Removed

- I've removed XY (#1000)

### Fixed

- I've fixed XY (#1000)

### Security

- I've improved the security in XY (#1000)

-->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example template shouldn't be removed.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, removed it in error. I've added it back

@jdevcs jdevcs added the Future Release For future release. label Sep 7, 2022
@jdevcs

jdevcs commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

This PR is doc change so can merge without status of all CI actions.

This was referenced Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Documentation Relates to project wiki or documentation Future Release For future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants