This repository was archived by the owner on Mar 5, 2025. It is now read-only.
4.x info messages in 1.x - #5412
Merged
Merged
Conversation
jdevcs
requested review from
Muhammad-Altabba,
Spacesai1or,
avkos,
luu-alex and
nikoulai
September 1, 2022 20:19
|
Your Render PR Server URL is https://web3-js-pr-5412.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cc8h7k02i3mgkrt14vj0. |
jdevcs
marked this pull request as ready for review
September 2, 2022 10:34
avkos
reviewed
Sep 2, 2022
avkos
suggested changes
Sep 2, 2022
avkos
left a comment
Contributor
There was a problem hiding this comment.
It will be great to fix not working links
Contributor
Author
Pull Request Test Coverage Report for Build 3007245510Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
avkos
approved these changes
Sep 6, 2022
nikoulai
approved these changes
Sep 6, 2022
luu-alex
reviewed
Sep 7, 2022
luu-alex
reviewed
Sep 7, 2022
luu-alex
reviewed
Sep 7, 2022
Contributor
|
just a small comment, otherwise lgtm |
luu-alex
approved these changes
Sep 7, 2022
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
#5411
Also removed broken badges
Type of change
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.