This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Replace private _config with public config in web3_config.ts - #5950
Merged
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
39b5f2e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3bba7b24.web3-js-docs.pages.dev |
| Branch Preview URL: | https://wyatt-4-x-5802-contract-web3.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5950 +/- ##
==========================================
+ Coverage 82.04% 82.14% +0.09%
==========================================
Files 137 137
Lines 5983 5981 -2
Branches 1572 1572
==========================================
+ Hits 4909 4913 +4
+ Misses 1074 1068 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Spacesai1or
marked this pull request as ready for review
March 24, 2023 04:37
Spacesai1or
requested review from
Muhammad-Altabba,
avkos,
jdevcs,
luu-alex and
nikoulai
March 24, 2023 04:47
16 tasks
nikoulai
approved these changes
Mar 24, 2023
avkos
approved these changes
Mar 24, 2023
Muhammad-Altabba
approved these changes
Mar 27, 2023
jdevcs
approved these changes
Mar 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5802 was fixed by making
Web3Config.configapublicproperty instead of forcing the use of the getter methodgetConfig(addresses the issue brought up in the beginning of this comment). I think ideally we'd want to keepWeb3Config.configprivateand replacegetConfigandsetConfigwith a standard getter and setter, but this wouldn't fix #5802 becauseContractspreads the providedWeb3Contextwhich causes providerOrContext to be a simple object rather than an instance ofWeb3Configwhere the getter for_configwould be available. This could be accounted for, but in doing so a substantial amount of changes were needed and I opted to go the route of fewer changes to fix #5802Removed
web3-core
getConfigmethod fromWeb3Configclass,configis now public and accessible usingWeb3Config.config(Replaceprivate _configwithpublic configinweb3_config.ts#5950)closes #5802