Ensure a fixed version for "@types/ws": "8.5.3" - #6309
Conversation
and move it to devDependencies
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
79afd63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34f7eea4.web3-js-docs.pages.dev |
| Branch Preview URL: | https://6303-error-node-modules-type.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6309 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 199 199
Lines 7706 7706
Branches 2115 2115
=======================================
Hits 6850 6850
Misses 856 856
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jdevcs
left a comment
There was a problem hiding this comment.
Once this PR is merged, we can again use latest patch? DefinitelyTyped/DefinitelyTyped#65849
jdevcs
left a comment
There was a problem hiding this comment.
also will be helpful for users if its error is mentioned in changelog, Thanks
and update the CHANGELOG.md
Ensure a fixed version for
"@types/ws": "8.5.3"and move it todevDependencies.Description
Fixes #6303
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.