Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Tests fix due to geth release changes - #6354

Merged
jdevcs merged 9 commits into
4.xfrom
junaid/4xnewgethreleaseissuefix
Aug 17, 2023
Merged

Tests fix due to geth release changes#6354
jdevcs merged 9 commits into
4.xfrom
junaid/4xnewgethreleaseissuefix

Conversation

@jdevcs

@jdevcs jdevcs commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes of failing geth http tests:
https://github.com/web3/web3.js/actions/runs/5835730499/job/15828038229?pr=6346#step:5:282
https://github.com/web3/web3.js/actions/runs/5835730499/job/15828038229?pr=6346#step:5:301
https://github.com/web3/web3.js/actions/runs/5835730499/job/15828038229?pr=6346#step:5:319
https://github.com/web3/web3.js/actions/runs/5835730499/job/15828038229?pr=6346#step:5:1153

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions

github-actions Bot commented Aug 14, 2023

Copy link
Copy Markdown

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 653 KB 653 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 636 KB 636 KB 0 0.00%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@codecov

codecov Bot commented Aug 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6354 (4fcd0d9) into 4.x (622174c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6354   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files         199      199           
  Lines        7722     7722           
  Branches     2127     2127           
=======================================
  Hits         6881     6881           
  Misses        841      841           
Flag Coverage Δ
UnitTests 89.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2023

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fcd0d9
Status: ✅  Deploy successful!
Preview URL: https://f678b299.web3-js-docs.pages.dev
Branch Preview URL: https://junaid-4xnewgethreleaseissue.web3-js-docs.pages.dev

View logs

@avkos avkos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes.
Unfortunately, we still have some tests which do not pass.

@jdevcs

jdevcs commented Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for these fixes. Unfortunately, we still have some tests which do not pass.

I'll fix ws and ipc in another PR, after merging it? as ws and ipc are not due to same issue I think.

@jdevcs
jdevcs requested a review from avkos August 15, 2023 15:44
- run: yarn test:e2e:${{ matrix.backend }}:${{ matrix.mode }}
shell: bash

e2e-sync:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from 1.12.0 geth doesn't support ethash and stops with : "Fatal: Failed to register the Ethereum service: ethash is only supported as a historical component of already merged networks" so sync test scripts are removed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. do we need somehow to adapt our sync test? Do we need to create an issue for this?

@jdevcs jdevcs Aug 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Eth mainnet is on POS so we dnt need to invoke sync tests, but let these be in tests so any one using web3.js on other NWs with POW, the functionality will be there and we can invoke tests manually if want to debug or see.

@jdevcs jdevcs self-assigned this Aug 17, 2023
@jdevcs
jdevcs merged commit 7a38fee into 4.x Aug 17, 2023
@jdevcs
jdevcs deleted the junaid/4xnewgethreleaseissuefix branch August 17, 2023 15:17
@mconnelly8 mconnelly8 linked an issue Aug 17, 2023 that may be closed by this pull request
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fix due to geth release changes

3 participants