This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fixed accounts.sign invalid length because of missing leading zero - #6411
Merged
Conversation
emn178
requested review from
Muhammad-Altabba,
avkos,
jdevcs and
luu-alex
as code owners
September 9, 2023 13:45
Contributor
|
Thanks for the PR! can you update the changelog as well |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6411 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 199 199
Lines 7723 7723
Branches 2128 2128
=======================================
Hits 6882 6882
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
luu-alex
approved these changes
Sep 10, 2023
jdevcs
approved these changes
Sep 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes r and s should have leading zero, but current version has bug and return invalid length, for example:
It should be
In old version, e.g. 1.x it returns correct result like above.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.