Stress Tests 2 - QA Tests - #6583
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
cca9311
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e75f9a12.web3-js-docs.pages.dev |
| Branch Preview URL: | https://ok-5563-stress-tests-2---qa.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6583 +/- ##
==========================================
+ Coverage 87.37% 89.54% +2.17%
==========================================
Files 197 215 +18
Lines 7548 8276 +728
Branches 2059 2242 +183
==========================================
+ Hits 6595 7411 +816
+ Misses 953 865 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jdevcs
left a comment
jdevcs
left a comment
There was a problem hiding this comment.
lgtm, just need above change
Muhammad-Altabba
left a comment
Muhammad-Altabba
left a comment
There was a problem hiding this comment.
I added the review points t #6595 as it already contains the commits of this PR.
| const c = new web3.eth.Contract(contractData.abi); | ||
| const contract = await c.deploy(deployOptions).send(sendOptions); | ||
|
|
||
| console.time(`Send huge data [${i}]`); |
jdevcs
left a comment
jdevcs
left a comment
There was a problem hiding this comment.
approved, for improvements you can do in other wip Stress testing PR or followup PR/issue.
4 participants
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #5563
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.