Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

fix unit tests - #6614

Merged
luu-alex merged 1 commit into
4.xfrom
fix-unit-test
Nov 23, 2023
Merged

fix unit tests#6614
luu-alex merged 1 commit into
4.xfrom
fix-unit-test

Conversation

@luu-alex

@luu-alex luu-alex commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Description

fixing unit test from socketprovider suite

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions

Copy link
Copy Markdown

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 589 KB 589 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 571 KB 571 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a822fa1
Status: ✅  Deploy successful!
Preview URL: https://9e0c3de1.web3-js-docs.pages.dev
Branch Preview URL: https://fix-unit-test.web3-js-docs.pages.dev

View logs

@codecov

codecov Bot commented Nov 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6614 (a822fa1) into 4.x (4358140) will increase coverage by 2.00%.
Report is 114 commits behind head on 4.x.
The diff coverage is 92.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6614      +/-   ##
==========================================
+ Coverage   87.37%   89.38%   +2.00%     
==========================================
  Files         197      215      +18     
  Lines        7548     8306     +758     
  Branches     2059     2248     +189     
==========================================
+ Hits         6595     7424     +829     
+ Misses        953      882      -71     
Flag Coverage Δ
UnitTests 89.38% <92.97%> (+2.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex
luu-alex marked this pull request as ready for review November 21, 2023 16:51
@luu-alex luu-alex changed the title update socket provider test fix unit tests Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants