Support PHP 8.0#257
Merged
Merged
Conversation
484702d to
cc7d01e
Compare
sc0Vu
approved these changes
Mar 7, 2022
Member
sc0Vu
left a comment
There was a problem hiding this comment.
LGTM, I'll merge once ci test passed.
Member
|
Thanks, it works on php8.0. |
Contributor
Author
|
@sc0Vu The tests were supposed to be passing. But in the "Cache composer packages" step it is fetching a cache of an incorrect composer.lock file. The cache key is not taking into account the version of PHP being run in the test. I will add a commit that fixes this. Explanation: For PHP 8.x the The test was getting a cached version of composer.lock that was generated by PHP 8, that locked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add support for PHP 8.0 and bumps minimum version for package to 7.2 (instead of 7.1).
The wrong preg_match with this test that broke the tests to PHP 8.0. The phpseclib returns empty when sending an invalid hexadecimal string using PHP 7 (making the old test pass), but for PHP 8 it throws an exception (since the correct behavior is to send only hexadecimal strings).