Skip to content

feat(settings): add tab grouping opt-out - #2726

Merged
webbrain-one merged 54 commits into
webbrain-one:mainfrom
fly1d:codex/tab-group-setting
Aug 10, 2026
Merged

feat(settings): add tab grouping opt-out#2726
webbrain-one merged 54 commits into
webbrain-one:mainfrom
fly1d:codex/tab-group-setting

Conversation

@fly1d

@fly1d fly1d commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a default-on setting to control automatic WebBrain tab grouping
  • honor the opt-out for toolbar, context-menu, install, and agent-created tabs
  • keep existing groups unchanged when the setting is disabled
  • include the preference in config export/import
  • localize the setting across all supported extension languages

Fixes #2675

Tests

  • npm run test:toolbar-guard (33/33)
  • npm run test:security (60/60)
  • npm test (new regression passes; overall 1546 passed, 20 unrelated ENOENT failures because this sparse checkout excludes web/, docs/, and assets/)
  • JavaScript syntax checks and git diff --check

fly1d added 30 commits August 10, 2026 12:23
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

@fly1d is attempting to deploy a commit to the esokullu's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a default-on, portable setting to disable automatic WebBrain tab grouping across Chrome and Firefox.

Changes:

  • Adds the accessible setting and localized labels.
  • Applies the preference to background and agent-created tabs.
  • Includes the preference in config import/export and regression tests.

One non-blocking documentation issue was identified.

Reviewed changes

Copilot reviewed 54 out of 59 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/run.js Tests preference defaults, parity, UI, config, and locales.
src/firefox/src/ui/settings.js Loads and persists the Firefox setting.
src/firefox/src/ui/settings.html Adds the Firefox toggle.
src/firefox/src/ui/locales/zh.js Adds Chinese strings.
src/firefox/src/ui/locales/vi.js Adds Vietnamese strings.
src/firefox/src/ui/locales/uk.js Adds Ukrainian strings.
src/firefox/src/ui/locales/tr.js Adds Turkish strings.
src/firefox/src/ui/locales/tl.js Adds Filipino strings.
src/firefox/src/ui/locales/th.js Adds Thai strings.
src/firefox/src/ui/locales/ru.js Adds Russian strings.
src/firefox/src/ui/locales/pt.js Adds Portuguese strings.
src/firefox/src/ui/locales/pl.js Adds Polish strings.
src/firefox/src/ui/locales/nl.js Adds Dutch strings.
src/firefox/src/ui/locales/ms.js Adds Malay strings.
src/firefox/src/ui/locales/ko.js Adds Korean strings.
src/firefox/src/ui/locales/ja.js Adds Japanese strings.
src/firefox/src/ui/locales/id.js Adds Indonesian strings.
src/firefox/src/ui/locales/hi.js Adds Hindi strings.
src/firefox/src/ui/locales/he.js Adds Hebrew strings.
src/firefox/src/ui/locales/fr.js Adds French strings.
src/firefox/src/ui/locales/fa.js Adds Persian strings.
src/firefox/src/ui/locales/es.js Adds Spanish strings.
src/firefox/src/ui/locales/en.js Adds English strings.
src/firefox/src/ui/locales/de.js Adds German strings.
src/firefox/src/ui/locales/bn.js Adds Bengali strings.
src/firefox/src/ui/locales/ar.js Adds Arabic strings.
src/firefox/src/tab-group-preference.js Defines the preference helper.
src/firefox/src/config-transfer.js Adds config portability.
src/firefox/src/background.js Guards automatic background grouping.
src/firefox/src/agent/agent.js Guards agent-created tab grouping.
src/chrome/src/ui/settings.js Loads and persists the Chrome setting.
src/chrome/src/ui/settings.html Adds the Chrome toggle.
src/chrome/src/ui/locales/zh.js Adds Chinese strings.
src/chrome/src/ui/locales/vi.js Adds Vietnamese strings.
src/chrome/src/ui/locales/uk.js Adds Ukrainian strings.
src/chrome/src/ui/locales/tr.js Adds Turkish strings.
src/chrome/src/ui/locales/tl.js Adds Filipino strings.
src/chrome/src/ui/locales/th.js Adds Thai strings.
src/chrome/src/ui/locales/ru.js Adds Russian strings.
src/chrome/src/ui/locales/pt.js Adds Portuguese strings.
src/chrome/src/ui/locales/pl.js Adds Polish strings.
src/chrome/src/ui/locales/nl.js Adds Dutch strings.
src/chrome/src/ui/locales/ms.js Adds Malay strings.
src/chrome/src/ui/locales/ko.js Adds Korean strings.
src/chrome/src/ui/locales/ja.js Adds Japanese strings.
src/chrome/src/ui/locales/id.js Adds Indonesian strings.
src/chrome/src/ui/locales/hi.js Adds Hindi strings.
src/chrome/src/ui/locales/he.js Adds Hebrew strings.
src/chrome/src/ui/locales/fr.js Adds French strings.
src/chrome/src/ui/locales/fa.js Adds Persian strings.
src/chrome/src/ui/locales/es.js Adds Spanish strings.
src/chrome/src/ui/locales/en.js Adds English strings.
src/chrome/src/ui/locales/de.js Adds German strings.
src/chrome/src/ui/locales/bn.js Adds Bengali strings.
src/chrome/src/ui/locales/ar.js Adds Arabic strings.
src/chrome/src/tab-group-preference.js Defines the preference helper.
src/chrome/src/config-transfer.js Adds config portability.
src/chrome/src/background.js Guards background grouping; updates documentation.
src/chrome/src/agent/agent.js Guards agent-created tab grouping.
Files not reviewed (5)
  • src/chrome/src/ui/locales/bn.js: Generated file
  • src/chrome/src/ui/locales/hi.js: Generated file
  • src/chrome/src/ui/locales/ru.js: Generated file
  • src/chrome/src/ui/locales/th.js: Generated file
  • src/chrome/src/ui/locales/uk.js: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/chrome/src/background.js Outdated
Comment on lines +1042 to +1044
// individual tabs. When automatic grouping is enabled and the user clicks
// the action, the source tab joins (or seeds) a tab group; the panel is
// enabled only for tabs in that group.
@webbrain-one
webbrain-one merged commit ccf5da8 into webbrain-one:main Aug 10, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue from discord

3 participants