feat(settings): add tab grouping opt-out - #2726
Merged
Merged
Conversation
|
@fly1d is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a default-on, portable setting to disable automatic WebBrain tab grouping across Chrome and Firefox.
Changes:
- Adds the accessible setting and localized labels.
- Applies the preference to background and agent-created tabs.
- Includes the preference in config import/export and regression tests.
One non-blocking documentation issue was identified.
Reviewed changes
Copilot reviewed 54 out of 59 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/run.js |
Tests preference defaults, parity, UI, config, and locales. |
src/firefox/src/ui/settings.js |
Loads and persists the Firefox setting. |
src/firefox/src/ui/settings.html |
Adds the Firefox toggle. |
src/firefox/src/ui/locales/zh.js |
Adds Chinese strings. |
src/firefox/src/ui/locales/vi.js |
Adds Vietnamese strings. |
src/firefox/src/ui/locales/uk.js |
Adds Ukrainian strings. |
src/firefox/src/ui/locales/tr.js |
Adds Turkish strings. |
src/firefox/src/ui/locales/tl.js |
Adds Filipino strings. |
src/firefox/src/ui/locales/th.js |
Adds Thai strings. |
src/firefox/src/ui/locales/ru.js |
Adds Russian strings. |
src/firefox/src/ui/locales/pt.js |
Adds Portuguese strings. |
src/firefox/src/ui/locales/pl.js |
Adds Polish strings. |
src/firefox/src/ui/locales/nl.js |
Adds Dutch strings. |
src/firefox/src/ui/locales/ms.js |
Adds Malay strings. |
src/firefox/src/ui/locales/ko.js |
Adds Korean strings. |
src/firefox/src/ui/locales/ja.js |
Adds Japanese strings. |
src/firefox/src/ui/locales/id.js |
Adds Indonesian strings. |
src/firefox/src/ui/locales/hi.js |
Adds Hindi strings. |
src/firefox/src/ui/locales/he.js |
Adds Hebrew strings. |
src/firefox/src/ui/locales/fr.js |
Adds French strings. |
src/firefox/src/ui/locales/fa.js |
Adds Persian strings. |
src/firefox/src/ui/locales/es.js |
Adds Spanish strings. |
src/firefox/src/ui/locales/en.js |
Adds English strings. |
src/firefox/src/ui/locales/de.js |
Adds German strings. |
src/firefox/src/ui/locales/bn.js |
Adds Bengali strings. |
src/firefox/src/ui/locales/ar.js |
Adds Arabic strings. |
src/firefox/src/tab-group-preference.js |
Defines the preference helper. |
src/firefox/src/config-transfer.js |
Adds config portability. |
src/firefox/src/background.js |
Guards automatic background grouping. |
src/firefox/src/agent/agent.js |
Guards agent-created tab grouping. |
src/chrome/src/ui/settings.js |
Loads and persists the Chrome setting. |
src/chrome/src/ui/settings.html |
Adds the Chrome toggle. |
src/chrome/src/ui/locales/zh.js |
Adds Chinese strings. |
src/chrome/src/ui/locales/vi.js |
Adds Vietnamese strings. |
src/chrome/src/ui/locales/uk.js |
Adds Ukrainian strings. |
src/chrome/src/ui/locales/tr.js |
Adds Turkish strings. |
src/chrome/src/ui/locales/tl.js |
Adds Filipino strings. |
src/chrome/src/ui/locales/th.js |
Adds Thai strings. |
src/chrome/src/ui/locales/ru.js |
Adds Russian strings. |
src/chrome/src/ui/locales/pt.js |
Adds Portuguese strings. |
src/chrome/src/ui/locales/pl.js |
Adds Polish strings. |
src/chrome/src/ui/locales/nl.js |
Adds Dutch strings. |
src/chrome/src/ui/locales/ms.js |
Adds Malay strings. |
src/chrome/src/ui/locales/ko.js |
Adds Korean strings. |
src/chrome/src/ui/locales/ja.js |
Adds Japanese strings. |
src/chrome/src/ui/locales/id.js |
Adds Indonesian strings. |
src/chrome/src/ui/locales/hi.js |
Adds Hindi strings. |
src/chrome/src/ui/locales/he.js |
Adds Hebrew strings. |
src/chrome/src/ui/locales/fr.js |
Adds French strings. |
src/chrome/src/ui/locales/fa.js |
Adds Persian strings. |
src/chrome/src/ui/locales/es.js |
Adds Spanish strings. |
src/chrome/src/ui/locales/en.js |
Adds English strings. |
src/chrome/src/ui/locales/de.js |
Adds German strings. |
src/chrome/src/ui/locales/bn.js |
Adds Bengali strings. |
src/chrome/src/ui/locales/ar.js |
Adds Arabic strings. |
src/chrome/src/tab-group-preference.js |
Defines the preference helper. |
src/chrome/src/config-transfer.js |
Adds config portability. |
src/chrome/src/background.js |
Guards background grouping; updates documentation. |
src/chrome/src/agent/agent.js |
Guards agent-created tab grouping. |
Files not reviewed (5)
- src/chrome/src/ui/locales/bn.js: Generated file
- src/chrome/src/ui/locales/hi.js: Generated file
- src/chrome/src/ui/locales/ru.js: Generated file
- src/chrome/src/ui/locales/th.js: Generated file
- src/chrome/src/ui/locales/uk.js: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1042
to
+1044
| // individual tabs. When automatic grouping is enabled and the user clicks | ||
| // the action, the source tab joins (or seeds) a tab group; the panel is | ||
| // enabled only for tabs in that group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2675
Tests
npm run test:toolbar-guard(33/33)npm run test:security(60/60)npm test(new regression passes; overall 1546 passed, 20 unrelated ENOENT failures because this sparse checkout excludesweb/,docs/, andassets/)git diff --check