-
Notifications
You must be signed in to change notification settings - Fork 4
Provide a semantic bundle configuration #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b6102c to
9234a86
Compare
Removed "optional", as the `guide.xml` is always included. You can still chose not include the guide in your routing, but that's a little bit too short for me to call it "optional".
MalteWunsch
reviewed
May 30, 2022
Member
Author
|
Thank you for the exhaustive review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to set up service configuration like this:
... and using the
Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.inlineorWebfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.esiparent services, with this PR you can instead write:The first is a shorthand notation to register the
my-shortcodeshortcode which will be rendered with theinlinestrategy. The second is a bit more elaborate, but allows to specifyesias the rendering strategy.