More detail on append() aborting and other semantics - #104
Merged
Conversation
See discussions in #92 (comment) onward.
lozy219
approved these changes
Apr 21, 2025
lozy219
left a comment
lozy219
left a comment
Contributor
There was a problem hiding this comment.
Thanks! The change looks good to me.
|
I think it may be fine to remove for now, but abort() is definitely something we're going to want to support eventually. See my comment on #92 (comment), abort is important for cancelling expensive append() operations. |
domenic
changed the title
Contributor
Author
|
Needs re-review now that I've redone this to allow aborting. |
|
new wording lgtm, thanks! |
clarkduvall
approved these changes
Apr 23, 2025
lozy219
suggested changes
Apr 24, 2025
lozy219
approved these changes
Apr 24, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 9, 2025
This CL aligns the implementation with webmachinelearning/prompt-api#95 and webmachinelearning/prompt-api#104 Bug: 409355678 Change-Id: I0c119242b5f3fb2e01feada1852a6e7b57a9d3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6468355 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Mingyu Lei <leimy@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1457987}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussions in #92 (comment) onward.
@lozy219 PTAL! Also cc @clarkduvall.