Fixed warnings, and made changes to the privacy considerations making it more consistent with the explainer - #74
Conversation
I found this section in explainer is missing in the spec so I added it.
| Please see [[WRITING-ASSISTANCE-APIS#privacy]] for a discussion of privacy considerations for the translator and language detector APIs. That text was written to apply to all APIs sharing the same infrastructure, as noted in [[#dependencies]]. | ||
|
|
||
|
|
||
| <h3 id="iframe-privacy"> Permissions policy, iframes, and workers </h3> |
There was a problem hiding this comment.
The spec's translator-permissions-policy section already covers permissions policy integration.
There was a problem hiding this comment.
Hi @michaelwasserman , sorry for the late response. It has been a bit hectic. I have two points for this change:
-
in the spec, this is not part of privacy considerations. I think it should move there.
-
The explainer is more comprehensive than the actual spec in describing the topic, which I think it should be minimum the other way. So I still suggest explainer and spec text should be consistent.
| <iframe src="https://example.com/" allow="translator language-detector"></iframe> | ||
| </xmp> | ||
|
|
||
| These APIs are currently not available in workers, due to the complexity of establishing a responsible document for each worker in order to check the permissions policy status. See [this discussion](https://github.com/webmachinelearning/translation-api/issues/18#issuecomment-2705630392) for more. It may be possible to loosen this restriction over time, if use cases arise. |
There was a problem hiding this comment.
This text is already in the explainer, and the spec includes the correct Exposed=Window scope in the interface definitions.
I don't think this prose about workers and extensions is strictly needed in the spec, and isn't quite appropriate in the current form. Maybe a shorter <note> linking #18 would be appropriate.
There was a problem hiding this comment.
noted, let me think how I can address it... I will do another PR next week on this.
toreini
changed the title
toreini
changed the title
| <h2 id="privacy">Privacy considerations</h2> | ||
|
|
||
| Please see [[WRITING-ASSISTANCE-APIS#privacy]] for a discussion of privacy considerations for the translator and language detector APIs. That text was written to apply to all APIs sharing the same infrastructure, as noted in [[#dependencies]]. | ||
| <h3 id="language-detector-iframe-policy"><code>iframe</code> Permissions</h3> |
There was a problem hiding this comment.
| <h3 id="language-detector-iframe-policy"><code>iframe</code> Permissions</h3> | |
| <h3 id="iframe-policy-example"><code>iframe</code> Permissions</h3> |
| <pre class=link-defaults> | ||
| spec:proofreader-api; type:dfn; text:get the language availabilities partition | ||
| spec:writing-assistance-apis; type:dfn; text:get the language availabilities partition | ||
| spec:proofreader-api; type:dfn; text:compute language availability | ||
| spec:writing-assistance-apis; type:dfn; text:compute language availability | ||
| </pre> |
There was a problem hiding this comment.
I've removed the duplicate definitions from [PROOFREADER-API] so you should be able to just keep the instances from [WRITING-ASSISTANCE-APIS].
|
|
||
| <h3 id="language-detector-permissions-policy">Permissions policy integration</h3> | ||
|
|
||
| Access to the translator API is gated behind the [=policy-controlled feature=] "<dfn permission>translator</dfn>", which has a [=policy-controlled feature/default allowlist=] of <code>[=default allowlist/'self'=]</code>. |
There was a problem hiding this comment.
Keep the per-API permissions policy integration sections.
3 participants
I found this section in explainer is missing in the spec so I added it.
Preview | Diff