Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Add implementation and tests for prelu op#212

Merged
BruceDai merged 2 commits intowebmachinelearning:masterfrom
BruceDai:add_prelu
Mar 14, 2023
Merged

Add implementation and tests for prelu op#212
BruceDai merged 2 commits intowebmachinelearning:masterfrom
BruceDai:add_prelu

Conversation

@BruceDai
Copy link
Copy Markdown
Collaborator

@BruceDai BruceDai commented Mar 8, 2023

@huningxin @Honry PTAL, thanks.

Comment thread test/ops/prelu.js
utils.checkValue(result.outputs.y, expected);
});

it('prelu broadcast 3d x 3d', async () => {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test could fail by Wasm backend (TF.js Wasm backend), reported this issue tensorflow/tfjs#7458 to TF.js.

Copy link
Copy Markdown
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BruceDai
Copy link
Copy Markdown
Collaborator Author

According to the comment for prelu's implementation webmachinelearning/webnn-baseline#35 (comment), also update prelu tests here, thanks.

@BruceDai BruceDai merged commit 7a8a330 into webmachinelearning:master Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants