Proposal: Drop support for PHP versions that are EOL

[tux-rampage]

All PHP versions < 7.2 are end of life and should no longer be used. It is harmful to support these outdated versions in the future.

Why?

• PHPUnit cannot be upgraded to 8 and above
• Newer language features cannot be adopted resulting in bloated or less readable code
• Users should not be encouraged to build technical debt

[Ocramius]

Yes please \o/

[zerkms]

Would this PR also add native typing to the Assert class as well then?

[orklah]

Would this PR also add native typing to the Assert class as well then?

Seems complicated in most assertions. For example, if Assert::string can only takes string, it defeats its whole purpose (taking something else and fail the assertion).

[zerkms]

@orklah I only meant those that can be typed: eg

     * @param mixed  $value
     * @param string $message

$message can be typed as string everywhere.

So, only places where @param at this very moment has non-mixed type (while I think that first argument should be mixed everywhere, but this would be a breaking change).

[Ocramius]

don't think we should have mixed everywhere, especially due to purity and PHP magic 😞

But yes, where we have type declarations, we can now have native type checks.

Please remember to not accept Stringable BTW 😅

[zerkms]

don't think we should have mixed everywhere, especially due to purity and PHP magic

I thought that too, but having alnum with string parameter requires you to first assert for string. It bloats code for no reason.

[Ocramius]

Depends: I use that kind of assertion mostly where strings are already the current type, and maybe they are even already ensured to be not empty 🤷‍♀️

Even then, adding more precise assertions is powerful, and we probably want a DSL for grouping them together instead.

[zerkms]

and we probably want a DSL for grouping them together instead.

oh nononononononononononononononononononononononononononononononononononononononononononononononononononononono

But anyway, you people enjoy your Saturday :-D

[Ocramius]

Well, you know that beberlei/assert has lazy composable assertions: I really wonder if we could port assertion composition into types, and therefore teach it to psalm 💪

[ptondereau]

It could be useful to also update phpunit version (^9.3) to have a full support a php 8 without ignoring platform requirements

[Nyholm]

Thank you. This suggestion has been merged into master.

I did not merge this PR because most of it changes/all had conflicts or were obsolete. I hope you don't mind.