Fix StyleCI checks - #223
Merged
Merged
Conversation
Ocramius
approved these changes
Nov 6, 2020
Nyholm
reviewed
Nov 20, 2020
Nyholm
left a comment
Nyholm
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this PR. I just have some questions
BackEndTea
approved these changes
Dec 2, 2020
BackEndTea
left a comment
BackEndTea
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
I think i'd like to get rid of styleci, in favor of just having php code sniffer or php code style fixer as a dependency. But this is fine, and fixes the issues at hand 👍
This was referenced Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.