Fix coroutine executor when using with promise#486
Merged
vladar merged 2 commits intowebonyx:0.13.xfrom Jun 6, 2019
Merged
Conversation
mcg-web
changed the title
mcg-web
changed the title
This was referenced Jun 2, 2019
mcg-web
force-pushed
the
fix-coroutine-when-using-promise
branch
from
5e8bc91 to
08d9493
Compare
Member
|
@jakubkulhan Can you please review? |
Contributor
Author
|
Thanks for review @jakubkulhan and @vladar for merging this. Now my tests are OK with 0.13.x dev branch can you please release a patch version @vladar ? What about the fix on master ? |
Member
|
@mcg-web Just published v0.13.5. I'll merge it to master branch. And curious to see your results on experimental executor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to support experimental coroutine executor (#397) in OverblogGraphBundle the integration fails when using promises.