Fixed grouping implementors fields for abstract types in QueryPlan#632
Merged
Merged
Conversation
Member
|
Makes sense, but before merging I need to understand if it breaks things for existing usages or not? If it does, we probably need a note in breaking changes. |
Member
|
I've resolved conflicts and merged the PR manually. But the question still holds. If this PR breaks something for existing users, please add a note about this in Upgrade.md (in a new PR). This change goes to a new major version, so breaking changes are expected but we still should at least warn users about those (if any). And thank you for the PR! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for fix #513 by adding support of grouping implementors fields for abstract types in QueryPlan at any nesting level, not only at root.