fix: handle undefined and null as stats value#302
Merged
Conversation
Contributor
Author
|
@evilebottnawi, done |
alexander-akait
approved these changes
Oct 25, 2018
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good work. Thanks for helping. Let's wait CI green.
Contributor
Author
|
Oh, you need to support Node 4. Il'll update the code. |
In certain cases depending on the inputFileSystem `stats` doesn't throw, but returns a falsey value such as `undefined` and `null`. In this case an error from globby will be thrown `Patterns must be a string or an array of strings`
Member
|
/cc @alan-agius4 Is everything finished and does this solve the problem? |
Contributor
Author
|
Yes it does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases depending on the inputFileSystem
statsdoesn't throw, but returns a falsey value such asundefinedandnull. In this case an error from globby will be thrownPatterns must be a string or an array of stringsRelates to: angular/angular-cli#12686