fix: downgrading normalize-url#399
Conversation
For ES5 support required in IE
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 4 4
Lines 408 408
Branches 84 84
=======================================
Hits 266 266
Misses 118 118
Partials 24 24Continue to review full report at Codecov.
|
|
Looks good, in future we should implement build stage for transpile package, but we can avoid this here |
|
Also don't forget move https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/src/hmr/hotModuleReplacement.js#L145 before |
|
You can do this in other PR |
|
Appreciate it. Been out of town this weekend. Will catch up as I do see there has been some activity. |
|
Yes, I written test for home too |
Fixes faceyspacey#174 Similar to the fix for mini-css-extract-plugin: - webpack/mini-css-extract-plugin#385 - webpack/mini-css-extract-plugin#399
Fixes #174 Similar to the fix for mini-css-extract-plugin: - webpack/mini-css-extract-plugin#385 - webpack/mini-css-extract-plugin#399
2 participants
This PR contains a:
Motivation / Use-Case
Downgrading normalize-url to close issues opened around ES5 support required in IE
Breaking Changes
Additional Info
Internet Explorer is awesome...
fix #385