fix(options): use filename mutated after instantiation#430
Merged
alexander-akait merged 1 commit intoJul 19, 2019
Merged
Conversation
alexander-akait
approved these changes
Jul 19, 2019
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Anyway, i am recommend don't do this, due webpack@5 will have built-in cache and using this approach is not good idea
This was referenced Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
A minor update from 0.6.0 to 0.7.0 broke my webpacker configuration. :(
In 13e9cbf (#381) the
moduleFilenamefunction was added. This change broke webpacker configurations that set a non-defaultfilenameoption.To explain further, if you view the webpacker plugins docs, options can be mutated after construction.
Excerpt from docs:
So, previously, I could set a filename like so:
but after 13e9cbf this was broken and instead you must set
moduleFilename: () => yourFilenameto fix it.Breaking Changes
None
Additional Info