changed property access for ES3 compatibility#363
Closed
sungkang wants to merge 3 commits into
Closed
Conversation
Member
|
@sungkang please fix CI error |
Author
|
attempted to resolve the CI error, it first seems to be related to the Node Security Platform service shutting down and nsp check being no longer is valid. |
Member
|
Close in favor #390 |
Member
|
Anyway thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixed an ES3 compatibility bug when accessing a property named "default".
Did you add tests for your changes?
No, but ran the existing tests that covered that functionality.
If relevant, did you update the README?
No
Summary
This was causing a backwards compatibility issue for applications running in IE8. The "default" property was accessed using dot notation and was changed to using square bracket notation.
Issue: #362
Does this PR introduce a breaking change?
No