Skip to content

Fix stylelint formatter path#49

Merged
JaKXz merged 1 commit into
webpack:masterfrom
karlhorky:fix-stylelint-formatter-path
Dec 18, 2016
Merged

Fix stylelint formatter path#49
JaKXz merged 1 commit into
webpack:masterfrom
karlhorky:fix-stylelint-formatter-path

Conversation

@karlhorky
Copy link
Copy Markdown
Contributor

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.238% when pulling 4f5f6ee on karlhorky:fix-stylelint-formatter-path into f8ad86f on vieron:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.238% when pulling 4f5f6ee on karlhorky:fix-stylelint-formatter-path into f8ad86f on vieron:master.

Comment thread index.js
var arrify = require('arrify');
var assign = require('object-assign');
var formatter = require('stylelint/dist/formatters/stringFormatter').default;
var formatter = require('stylelint/lib/formatters/stringFormatter');
Copy link
Copy Markdown

@jeddy3 jeddy3 Dec 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you use the public API here rather than an undocumented path:

var formatter = require('stylelint').formatters.string;

It'll save you from having to make changes like this in the future.

@agroves333
Copy link
Copy Markdown

Can we get this published to npm soon?

@JaKXz
Copy link
Copy Markdown
Contributor

JaKXz commented Dec 19, 2016

@agroves333 it should be in v0.4.2 (see #47). Are you not seeing it? (because I just tried it and it seems fine)

joshwiens pushed a commit that referenced this pull request Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants