Revert "Show help on no command" - #276
Merged
evenstensberg merged 1 commit intoFeb 22, 2018
Merged
Conversation
evenstensberg
approved these changes
Feb 22, 2018
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
dhruvdutt
added a commit
to dhruvdutt/webpack-cli
that referenced
this pull request
Feb 23, 2018
This reverts commit 4079570.
dhruvdutt
reviewed
Feb 23, 2018
dhruvdutt
left a comment
dhruvdutt
left a comment
Contributor
There was a problem hiding this comment.
bin/webpack.js 100644 → 100755
Do we also need to change file permissions?
Member
|
no |
Contributor
|
Seems like this PR changed it. Look at files diff. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #252
It shows help way to often, even when config file was provided.
I propose to revert this change until a better solution is found.