tests(no-options): add no options test - #285
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
@fokusferit @ematipico have a look
| expect(stdout[2]).toContain("Time: "); | ||
| expect(stdout[4]).toContain(""); | ||
| expect(stdout[5]).toContain("WARNING"); | ||
| expect(stdout[6]).toContain("The \'mode\' option has not been set"); |
There was a problem hiding this comment.
The message should be The 'mode' option has not been set. Set 'mode' option to 'development' or 'production' to enable defaults for this environment.
I know it's passing but it would be better to show the whole message
There was a problem hiding this comment.
I had initially thought to keep the whole message but then I read the blog post that production is default mode so we will change the latter part of this message.
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Test for all modes, output error log accordingly. Don't see any one touching dev/prod or none, just a general one
7731487 to
bc6a96c
Compare
|
@dhruvdutt Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@ev1stensberg Updated the tests to add modes. |
4 participants
What kind of change does this PR introduce?
Test
Did you add tests for your changes?
Yes
Summary
Improve env complex test to check if env array gets created with correct values.
Does this PR introduce a breaking change?
No
Other information
Related #124, #254