chore(ES6): changed 'var' into 'const' where convenient - #325
Merged
Conversation
webpack-bot
added
PR: unreviewed
PR: CI-not-ok
PR: CI-ok
and removed
PR: CI-not-ok
labels
evenstensberg
approved these changes
Mar 8, 2018
| ) => /** @param {string} filePath */ filePath => { | ||
| var sourceParts = templateDir.split(path.delimiter); | ||
| const sourceParts = templateDir.split(path.delimiter); | ||
| sourceParts.push.apply(sourceParts, filePath.split("/")); |
Member
There was a problem hiding this comment.
Mutable object, but okay..
Contributor
Author
There was a problem hiding this comment.
It doesn't get reassigned, so const is ok. Otherwise eslint would have failed :)
Member
There was a problem hiding this comment.
The .push method is mutating it, ( even though the push method is immutable ) but that's another thing :D
sendilkumarn
approved these changes
Mar 9, 2018
sendilkumarn
left a comment
sendilkumarn
left a comment
Contributor
There was a problem hiding this comment.
minor comment otherwise LGTM 👍
| var yeoman = require("yeoman-environment"); | ||
| var LoaderGenerator = require("../generators/loader-generator").LoaderGenerator; | ||
| const yeoman = require("yeoman-environment"); | ||
| const LoaderGenerator = require("../generators/loader-generator").LoaderGenerator; |
Contributor
There was a problem hiding this comment.
can we use this const { LoaderGenerator } = require("../generators/loader-generator") ?
dhruvdutt
suggested changes
Mar 9, 2018
| var yeoman = require("yeoman-environment"); | ||
| var PluginGenerator = require("../generators/plugin-generator").PluginGenerator; | ||
| const yeoman = require("yeoman-environment"); | ||
| const PluginGenerator = require("../generators/plugin-generator").PluginGenerator; |
Contributor
There was a problem hiding this comment.
Can you change to const { PluginGenerator } here as well?
Member
There was a problem hiding this comment.
Can we use ES6 destructing now? Cool!
| var someOtherVar = somethingElse; | ||
| var otherPackage = require('other-package'); | ||
| const packageName = require('package-name'); | ||
| const someOtherconst = somethingElse; |
Contributor
There was a problem hiding this comment.
someOtherconstsomeOtherConst
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@ev1stensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @dhruvdutt Please review the new changes. |
|
@ev1stensberg The tests look fine, but there are code style issue in your Pull Request. Please review the following: See complete report here. |
This was referenced Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor, removed last references to
varDid you add tests for your changes?
No, but I updated one snapshot
If relevant, did you update the documentation?
No
Summary
Slowly moving to ES6
Does this PR introduce a breaking change?
No