fix(entry): fix a bug when --display-entrypoints=false does not hide entries - #464
Conversation
|
|
|
Just out of curiosity, what was the value of |
|
|
||
| ifArg("display-entrypoints", function(bool) { | ||
| if (bool) outputOptions.entrypoints = true; | ||
| outputOptions.entrypoints = !!bool; |
There was a problem hiding this comment.
Double boolean trick is enough to flip it correctly. Used it myself, but it might be some pitfalls, so might be better to do a strict equal instead if (bool === true)
There was a problem hiding this comment.
Yes, The trick is redundant。
The param:bool is true or false anyhow!
|
Could we add a test? |
dhruvdutt
left a comment
dhruvdutt
left a comment
There was a problem hiding this comment.
Thanks for your contributions. 🎉
|
Hi @sfger. Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
|
@webpack-bot: |
evenstensberg
changed the title
--display-entrypoints=false does not hide entries--display-entrypoints=false does not hide entries
evenstensberg
changed the title
--display-entrypoints=false does not hide entries--display-entrypoints=false does not hide entries
evenstensberg
changed the title
--display-entrypoints=false does not hide entries--display-entrypoints=false does not hide entries
6 participants
What kind of change does this PR introduce?
Fix bug: #463
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Fix bug: #463
Does this PR introduce a breaking change?
NO
Other information