Skip to content

fix(generate-loader/plugin): include example template#574

Merged
dhruvdutt merged 2 commits into
webpack:masterfrom
dhruvdutt:fix/572
Aug 25, 2018
Merged

fix(generate-loader/plugin): include example template#574
dhruvdutt merged 2 commits into
webpack:masterfrom
dhruvdutt:fix/572

Conversation

@dhruvdutt

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary
We generate plugins and loader template from the example and test directories which were excluded previously from the npm package.

Does this PR introduce a breaking change?
No

Other information
Fixes #572

@dhruvdutt dhruvdutt changed the title fix(generate-loader/plugin): include example template in npm package fix(generate-loader/plugin): include example template Aug 25, 2018
@dhruvdutt

Copy link
Copy Markdown
Contributor Author

@ev1stensberg Can you please merge this and do a release?

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 💙

@webpack-bot

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@dhruvdutt dhruvdutt merged commit d26ea82 into webpack:master Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: require(...).default is not a function

4 participants