Fix: fix prompt-installation #572

[duzy]

the strange things in this fix is about packages -- if it's not indicating the sub-command or a list of commands?

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information
Fixes #572

[jsf-clabot]

All committers have signed the CLA.

[webpack-bot]

@duzy The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (failure) and fix these issues.

[evenstensberg]

Thanks! Mind filling in the issue template with a better description? :

[evenstensberg]

Can you try to make this a bit prettier with better variable names?

[duzy]

@ev1stensberg Hi Even, you might try refining the name as wish, I'd like to present this patch for discussion as I'm NOT quite certain about packages -- as the name literally suggested, it might have multiple package names? The other possible fix might be changing the @webpack-cli/xxx modules, e.g.

function serve() {
    blah(...)
    blah(...)
}

export abc;
export xyz;
export default serve;

as webpack-cli seems to expect any @webpack-cli/xxx to offer a default export as a function, which is rational. But webpack-cli deserves a type check.

// pseudo
let module = required(pathForCmd), func = module.default;
if (typeof func !== 'function') throw new exception('opps, @webpack-cli/'+packages+' not meeting the spec');
func(...args);

[ematipico]

Yes in theory the package that we want to load should export a default function and I think bombing an error is fine, in order to dictate a standard. Your pseudo solution looks fine

[evenstensberg]

Can you produce a PR that contains full naming conventions and try to make it so that the tests pass?

[evenstensberg]

Hi @duzy, how's it going? Do you need help?

[duzy]

Hi @evenstensberg , I'm working on other non-js projects. Just can't follow up in time. But yes, my JS project is using this patch and working so far. I will keep following up this thread.

[evenstensberg]

No worries