cli(color): fix color option

[jayjun]

What kind of change does this PR introduce?
Fix --color option to use supports-color properly.

Did you add tests for your changes?
No.

If relevant, did you update the documentation?
N/A

Summary
The --color option’s default is set to return

return require("supports-color").supportsColor

Added in supports-color 5.0.0 (chalk/supports-color#64), supportsColor is a function and not the test result. Because a function is truthy, colours are enabled irrespective of TTY and FORCE_COLOR settings.

return require("supports-color").stdout

is the correct way to use supports-color. It checks process.stdout.isTTY so there’s no need to do the same.

Does this PR introduce a breaking change?
No.

Other information
See #452 for the last attempted fix.

[jsf-clabot]

All committers have signed the CLA.

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[evenstensberg]

Guess this is fine..