Skip to content

fix(server): revert "union sock options"#2261

Merged
EslamHiko merged 1 commit into
nextfrom
revert-2047-union-sock-options
Sep 25, 2019
Merged

fix(server): revert "union sock options"#2261
EslamHiko merged 1 commit into
nextfrom
revert-2047-union-sock-options

Conversation

@EslamHiko
Copy link
Copy Markdown
Member

Reverts #2047

@EslamHiko EslamHiko force-pushed the revert-2047-union-sock-options branch from 170cb91 to 012c2d0 Compare September 25, 2019 16:56
@EslamHiko EslamHiko changed the title Revert "Union sock options" fix(server): revert "union sock options" Sep 25, 2019
@EslamHiko EslamHiko closed this Sep 25, 2019
@EslamHiko EslamHiko reopened this Sep 25, 2019
@EslamHiko EslamHiko merged commit adc1154 into next Sep 25, 2019
@EslamHiko EslamHiko deleted the revert-2047-union-sock-options branch September 25, 2019 18:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 26, 2019

Codecov Report

Merging #2261 into next will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2261      +/-   ##
==========================================
- Coverage   93.96%   93.93%   -0.04%     
==========================================
  Files          36       36              
  Lines        1310     1302       -8     
  Branches      372      369       -3     
==========================================
- Hits         1231     1223       -8     
  Misses         70       70              
  Partials        9        9
Impacted Files Coverage Δ
lib/Server.js 97.19% <100%> (-0.02%) ⬇️
lib/utils/addEntries.js 100% <100%> (ø) ⬆️
lib/utils/createConfig.js 98.19% <100%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe80fa4...012c2d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant