Skip to content

fix: remove basicConstraints extension from certificate #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 3 commits into from
Dec 18, 2019
Merged

fix: remove basicConstraints extension from certificate #2330

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd88651
fix: remove basicConstraints extension from certificate
akx Nov 26, 2019
4ce4804
Merge branch 'master' into https-fix
evilebottnawi Dec 5, 2019
d8161b9
Merge branch 'master' into https-fix
evilebottnawi Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: remove basicConstraints extension from certificate 
This fixes TLS on Chromium Linux (see #2313)

Based on #2313 (comment)
  • Loading branch information
@akx
akx committed Dec 2, 2019
commit bd88651d196f2aceccedc9f4ab29abfff79372e9
4 changes: 0 additions & 4 deletions lib/utils/createCertificate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ function createCertificate(attributes) {
days: 30,
keySize: 2048,
extensions: [
{
name: 'basicConstraints',
cA: true,
},
{
name: 'keyUsage',
keyCertSign: true,
Expand Down