feat(benchmark): support profiling#19789
Merged
alexander-akait merged 3 commits intowebpack:mainfrom Aug 11, 2025
Merged
Conversation
273b1e7 to
1407aea
Compare
1407aea to
6a4c4fd
Compare
Member
There was a problem hiding this comment.
Let's do changes step by step, otherwise diff are dirty and hard to read and understand
- Let's keep benchmarks in
testdirectory right (we can move them at the last step) - We keep generated code in
./test/js/<name>, so let's store generated code there (we want to rename this directory totest/outputs/<name>soon) - Let's add profiling and other feature to
BenchmarkTestCases.benchmark.mjs(and not only) in other PR, because I can't see diff due to moving files to other directory and it is hard to understand what we changed
Member
Author
|
Sorry! Indeed, I'll simplify this to only add profiling support and such |
Member
|
Also we are trying to using |
b0dd035 to
0e10311
Compare
CodSpeed Performance ReportMerging #19789 will degrade performances by 75.03%Comparing Summary
Benchmarks breakdown
|
Member
|
@avivkeller As you can see, our watch tests are not stable (not related to your changes), if you have time to look at what's wrong with them will be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya! @ovflowd mentioned to me that y'all are looking to speed up parts of Webpack. That's great, and I'm happy to help. Anyhow, I wanted to help, so I figured I'd start by looking at the benchmarks, and immediately noticed a few things I could improve: Benchmarks don't profile
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
The tests are the benchmarks
Does this PR introduce a breaking change?
I certainly hope not.
What needs to be documented once your changes are merged?
The documentation has already been updated