add support for github codespaces#80
Closed
Simon-Laux wants to merge 2 commits intomainfrom
Closed
Conversation
(but currently does not work, because github seems to have a bug where the other iframes with the other ports return the site from the main port)
Contributor
|
closing this for now. not sure what exactly it is even about :) |
Member
Author
Currently the webxdc dev tool does not work in github code spaces, this PR was a failed attempt to fix that. The different ports seemed to be an issue for how gh code spaces publishes ports, as you can see each iframe shows the simulator again instead of the app. For the future it could also make sense to think about alternative ways to simulate multiple instances that don't use ports, like https://gitlab.com/soapbox-pub/webxdc.app. Maybe that would work better in web IDE environments like github code spaces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But currently does not work, because github seems to have a bug, where the iframes with the other ports return the simulator from the main port:
Changing port visibility to public on all ports does not help.