cosmetic patch for collision on certain conditions#3598
Merged
wenzhixin merged 2 commits intowenzhixin:masterfrom Mar 12, 2018
Merged
cosmetic patch for collision on certain conditions#3598wenzhixin merged 2 commits intowenzhixin:masterfrom
wenzhixin merged 2 commits intowenzhixin:masterfrom
Conversation
the collision is faced when group-by-v2 plugin is used along w/ enabled detailView — if one expands one or more rows in a group into detailView mode & then clicks on tr.groupBy row to collapse this group, the source rows become hidden just as expected, but their detailView representations still stay visible & expanded applied patch fixes the issue
Collaborator
|
Please provide a jsFiddle to show this PR working, thanks! |
Contributor
Author
|
you are welcome 💁🏻 for convenience' sake I've produced the doublet to show both the unpatched collision & the patch for this nuisance the first part of sequence to reproduce the unpatched collision
the second & last part of sequence to test the patch
|
the rigorous testing [on patch fiddle](wenzhixin#3598 (comment)) revealed the prefix `.bootstrap-table .table > tbody > tr.groupBy +` which has been initially applied just to follow the existing style is redundant &, moreover, for this concrete case is harmful 'cause it brings the mess on selectors & leads to the fault of the whole patch scheme after all as you can see https://jsfiddle.net/juliyvchirkov/jdwLp29e unprefixed rule achieves the goal as initially planned
wenzhixin
pushed a commit
that referenced
this pull request
Mar 12, 2018
the rigorous testing [on patch fiddle](#3598 (comment)) revealed the prefix `.bootstrap-table .table > tbody > tr.groupBy +` which has been initially applied just to follow the existing style is redundant &, moreover, for this concrete case is harmful 'cause it brings the mess on selectors & leads to the fault of the whole patch scheme after all as you can see https://jsfiddle.net/juliyvchirkov/jdwLp29e unprefixed rule achieves the goal as initially planned
wenzhixin
added a commit
that referenced
this pull request
Mar 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the collision is faced when group-by-v2 plugin is used along w/ enabled detailView — if one expands one or more rows in a group into detailView mode & then clicks on tr.groupBy row to collapse this group, the source rows become hidden just as expected, but their detailView representations still stay visible & expanded
applied patch fixes the issue