Skip to content

cosmetic patch for collision on certain conditions#3598

Merged
wenzhixin merged 2 commits intowenzhixin:masterfrom
juliyvchirkov:patch-1
Mar 12, 2018
Merged

cosmetic patch for collision on certain conditions#3598
wenzhixin merged 2 commits intowenzhixin:masterfrom
juliyvchirkov:patch-1

Conversation

@juliyvchirkov
Copy link
Contributor

the collision is faced when group-by-v2 plugin is used along w/ enabled detailView — if one expands one or more rows in a group into detailView mode & then clicks on tr.groupBy row to collapse this group, the source rows become hidden just as expected, but their detailView representations still stay visible & expanded

applied patch fixes the issue

the collision is faced when group-by-v2 plugin is used along w/ enabled detailView — if one expands one or more rows in a group into detailView mode & then clicks on tr.groupBy row to collapse this group, the source rows become hidden just as expected, but their detailView representations still stay visible & expanded

applied patch fixes the issue
@djhvscf
Copy link
Collaborator

djhvscf commented Feb 13, 2018

Please provide a jsFiddle to show this PR working, thanks!

@djhvscf djhvscf added the needs example Need an example in order to confirm the issue or the PR. label Feb 13, 2018
@juliyvchirkov
Copy link
Contributor Author

you are welcome 💁🏻

for convenience' sake I've produced the doublet to show both the unpatched collision & the patch for this nuisance

the first part of sequence to reproduce the unpatched collision

steps to face the issue

  1. open the fiddle
  2. use [+] icons to expand one or more rows at one or more groups w/ detailsView representation
  3. click on group header row to collapse a group w/ rows expanded in the previous step
  4. face the issue

the second & last part of sequence to test the patch

steps to test the patch

  1. open the fiddle
  2. use [+] icons to expand one or more rows at one or more groups w/ detailsView representation
  3. click on group header row to collapse a group w/ rows expanded in the previous step
  4. get the confidence the case is done & explore css block of the fiddle to examine the patch itself

the rigorous testing [on patch fiddle](wenzhixin#3598 (comment)) revealed the prefix `.bootstrap-table .table > tbody > tr.groupBy +` which has been initially applied just to follow the existing style is redundant &,  moreover, for this concrete case is harmful 'cause it brings the mess on selectors & leads to the fault of the whole patch scheme after all

as you can see https://jsfiddle.net/juliyvchirkov/jdwLp29e unprefixed rule achieves the goal as initially planned
@wenzhixin wenzhixin merged commit dacb9b1 into wenzhixin:master Mar 12, 2018
wenzhixin pushed a commit that referenced this pull request Mar 12, 2018
the rigorous testing [on patch fiddle](#3598 (comment)) revealed the prefix `.bootstrap-table .table > tbody > tr.groupBy +` which has been initially applied just to follow the existing style is redundant &,  moreover, for this concrete case is harmful 'cause it brings the mess on selectors & leads to the fault of the whole patch scheme after all

as you can see https://jsfiddle.net/juliyvchirkov/jdwLp29e unprefixed rule achieves the goal as initially planned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs example Need an example in order to confirm the issue or the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants