IGNITE-28738 RU test: small code-quality cleanups#2
Merged
wernerdv merged 1 commit intoJun 27, 2026
Merged
Conversation
- IgniteContainer.stop(): drop the unconditional "shut down gracefully" log. The image entrypoint does not forward SIGTERM, so the await times out and the node is force-stopped via super.stop(); the message contradicted the preceding "Proceeding with forceful stop." warning. - IgniteContainer.testClassesJar(): null-check File.listFiles() (returns null on an unreadable dir) so a missing class directory fails with a clear IOException instead of an NPE in the loop. - IgniteRebalanceOnUpgradeTest: compare the post-put value as a boxed Integer too (the get(1000)-loop already does), so a missing key fails the assertion instead of NPE-ing on unboxing. - Scope the "bind communication to loopback" comment to macOS (on Linux it binds to 0.0.0.0) and drop a trailing-whitespace blank line. No behavioral change on the macOS path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, behavior-preserving code-quality cleanups on top of the RU testcontainers test. Verified green end-to-end on macOS (
IgniteRebalanceOnUpgradeTest, 1 test, ~357s) andtest-compileis clean.Changes
IgniteContainer.stop()— drop the unconditional"Ignite node … shut down gracefully."log. The image entrypoint does not forwardSIGTERM, so theawaittimes out and the node is force-stopped viasuper.stop(); the message directly contradicted the preceding"Proceeding with forceful stop."warning.IgniteContainer.testClassesJar()— null-checkFile.listFiles()(returnsnullon an unreadable directory) so a missing class directory fails with a clearIOExceptioninstead of an NPE inside the loop.IgniteRebalanceOnUpgradeTest— compare the post-putvalue as a boxedInteger(theget-loop already does this), so a missing key fails the assertion instead of NPE-ing on unboxing.0.0.0.0) so it no longer contradicts the code, and drop a trailing-whitespace blank line.No behavioral change on the macOS path.
🤖 Generated with Claude Code