Skip to content

Remove GitHub Actions security review bot#112

Merged
wesm merged 1 commit intomainfrom
delete-gha-code-review
Feb 9, 2026
Merged

Remove GitHub Actions security review bot#112
wesm merged 1 commit intomainfrom
delete-gha-code-review

Conversation

@wesm
Copy link
Owner

@wesm wesm commented Feb 9, 2026

I'm in the process of replacing this with a bot managed by https://roborev.io

Summary

  • Removes the custom GitHub Actions security review bot, replacing it with roborev
  • Deletes workflow, Python scripts, tests, documentation, and trusted-contributors config
  • Updates CODEOWNERS to remove references to deleted files

Files removed

  • .github/workflows/security-review.yml
  • .github/scripts/security_review.py
  • .github/scripts/test_security_review.py
  • .github/SECURITY_BOT.md
  • .github/trusted-contributors.json

Test plan

  • Verify no remaining references to deleted files
  • CODEOWNERS still protects workflows, dependencies, and security docs

🤖 Generated with Claude Code

Replacing with roborev for code reviews. Removes the workflow,
Python scripts, tests, documentation, and trusted-contributors config.
Updates CODEOWNERS to remove references to deleted files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Security Review: 3 High/Medium Issues Found

Claude's automated security review identified potential security concerns. Please review each finding below.


🚨 Removal of security-critical CODEOWNERS protections (high)

Location: .github/CODEOWNERS:8

This PR removes CODEOWNERS protection for .github/scripts/** and .github/trusted-contributors.json. While these files are being deleted in this PR, removing CODEOWNERS protection before deletion creates a window where malicious changes could be introduced to the repository structure without owner approval. The CODEOWNERS file should only be updated AFTER the protected files are confirmed deleted, or these lines should remain as documentation of the security model even if the files don't currently exist.


🚨 Complete removal of automated security review workflow (high)

Location: .github/workflows/security-review.yml:1

This PR removes the entire automated security review workflow that provided baseline security analysis for external contributions. This eliminates an important defense-in-depth layer for detecting command injection, SQL injection, path traversal, and credential exposure in PRs. If this removal is intentional, ensure human reviewers are aware they now bear full responsibility for security review of all external contributions, and consider documenting this change in SECURITY.md.


⚠️ Removal of security review automation script (medium)

Location: .github/scripts/security_review.py:1

The security_review.py script provided automated detection of common vulnerability patterns (SQL injection, command injection, path traversal, hardcoded secrets). Removing this script eliminates automated security checks for external PRs. While the workflow file removal already flags this concern, the script removal confirms this is a complete dismantling of the automated security review infrastructure rather than a refactoring.


Powered by Claude 4.5 Sonnet — this is an automated review, false positives are possible.

@wesm wesm merged commit 63b11df into main Feb 9, 2026
4 checks passed
@roborev-ci
Copy link

roborev-ci bot commented Feb 9, 2026

roborev: Combined Review

Summary: Two medium-severity CI/CD security regressions remain after deduplication.

Medium

  • .github/CODEOWNERS:5
    Removing CODEOWNERS coverage for .github/scripts/** and .github/trusted-contributors.json weakens review gates for security-critical paths. Even if the files are deleted now, future additions under these paths would not require owner approval, increasing CI/CD supply-chain risk.
    Suggested fix: Restore CODEOWNERS coverage for .github/scripts/** (and other sensitive .github/ paths) or broaden to .github/**.

  • .github/workflows/security-review.yml:1
    Deleting the security-review workflow removes automated security checks for external PRs, reducing defense-in-depth and increasing reliance on manual review.
    Suggested fix: Replace with an alternative automated security review (SAST/bot) or enforce branch protection requiring explicit security reviewer approval for external PRs.


Synthesized from 4 reviews (agents: codex, gemini | types: security, review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant