Windows update support: .zip archives, .exe binary, testable pipeline#67
Merged
Windows update support: .zip archives, .exe binary, testable pipeline#67
Conversation
The update command always looked for .tar.gz assets and a binary named "msgvault", which fails on Windows where releases use .zip archives and the binary is "msgvault.exe". Changes: - Asset name uses .zip extension on Windows, .tar.gz elsewhere - Add extractZip with zip-slip path traversal protection (reuses sanitizeTarPath) - PerformUpdate dispatches to extractZip or extractTarGz based on asset suffix - installBinary uses msgvault.exe on Windows - Add TestExtractZip and TestExtractZipPathTraversal - Add CreateZip test helper Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Split PerformUpdate into download vs extract+install so the checksum verification, archive extraction, and binary installation can be tested end-to-end from a local archive without hitting GitHub. Adds hashFile helper, unexported installFromArchiveTo (checksum → extract → install), and exported InstallFromArchive wrapper. Includes 6 table-driven subtests covering zip, tar.gz, checksum mismatch, empty checksum, missing binary, and overwrite scenarios. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
downloadFile already computes SHA-256 while streaming the archive to disk, but PerformUpdate was discarding that hash and installFromArchiveTo would re-read the entire file in hashFile. Plumb the download checksum through a precomputedChecksum variadic parameter so online updates skip the redundant I/O pass. The public InstallFromArchive API and all existing tests continue to work unchanged. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
On Windows, os.MkdirTemp("", ...) can fail with "Access is denied"
when %TEMP% is restricted by antivirus, group policy, or permissions.
Add mkTempDir helper that tries the system temp dir first, then falls
back to creating a tmp/ subdirectory under the msgvault home directory.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move temp directory creation with fallback logic from update.go into a shared config.MkTempDir function. The function tries locations in order: preferred dirs (caller-specified) → system temp → ~/.msgvault/tmp/. This fixes a regression in build_cache.go where the CSV fallback temp dir was hardcoded to filepath.Dir(dbPath), which fails for read-only DB locations. It now passes the DB directory as a preferred dir but falls back through system temp and ~/.msgvault/tmp/ if that's inaccessible. Adds 5 test cases covering: system temp, preferred dir, empty preferred dir, inaccessible preferred dir, and full fallback to msgvault home. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Probe whether chmod 0500 actually restricts writes before asserting fallback behavior. Skips the test when running as root or with ACLs that still permit directory creation, avoiding flaky failures in CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Explain why the rename-then-copy pattern works on Windows (running executables can be renamed but not deleted/overwritten) and why the .old cleanup is expected to fail silently for the current process. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
I manually verified that the artifact from this PR can successfully do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ziparchives andmsgvault.exeon Windows instead of.tar.gzandmsgvaultinstallFromArchiveTofor a testable update-from-archive pipeline with zip extraction, path-traversal protection, and table-driven testsTest plan
go test ./internal/update/)make test)installFromArchiveTohappy paths (zip + tar.gz), checksum mismatch, empty checksum, missing binary, overwrite existing binarymsgvault updatedownloads.zipand extracts.exe🤖 Generated with Claude Code