feat(tempo): support P256 session vouchers#455
Open
deodad wants to merge 1 commit into
Open
Conversation
6796108 to
1862b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds direct TIP-1020 session voucher signing and verification for P256/WebCrypto voucher signers.
Motivation
Session voucher clients were signing through EIP-712
signTypedData, which usually produced Ethereum/secp256k1 signatures. TIP-1034 allows vouchers to use any TIP-1020 signature type, so delegated sessions need to sign the voucher digest directly with theauthorizedSigner.Changes
src/tempo/session/Voucher.tsand verify direct TIP-1020 envelopes withSignatureEnvelope.verify.voucherSignerwiring throughsrc/tempo/client/Session.ts,SessionManager.ts, andChannelOps.tsso P256/WebCrypto signers can be separate from the channel payer.authorizedSigner.Testing
pnpm buildpnpm check:typespnpm checkpnpm test src/tempo/session/Voucher.test.ts src/tempo/client/Session.test.ts- 2 files passed, 35 tests passedinnerValidDirectly: falseagainst the raw voucher digestpnpm test- failed locally due to RPC warmup timeouts/400s againstlocalhost:7545/*across unrelated suites and missing Playwright browser binary at~/Library/Caches/ms-playwright/chromium_headless_shell-1217/...; focused voucher/session tests passed before and after formatting.