Skip to content

fix handling of an []*string field #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whyrusleeping merged 2 commits into from
Jul 31, 2024
Merged

fix handling of an []*string field #101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57553c5
fix handling of an []*string field
brianolson Jul 31, 2024
41fee79
add testing
brianolson Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix handling of an []*string field
  • Loading branch information
@brianolson
brianolson committed Jul 31, 2024
commit 57553c5f50f6e6263e927b5800ce83854f0ea41a
7 changes: 4 additions & 3 deletions gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,9 +1372,10 @@ func (g Gen) emitCborUnmarshalSliceField(w io.Writer, f Field) error {

case reflect.String:
subf := Field{
Type: e,
Pkg: f.Pkg,
Name: f.Name + "[" + f.IterLabel + "]",
Type: e,
Pkg: f.Pkg,
Pointer: pointer,
Name: f.Name + "[" + f.IterLabel + "]",
}
err := g.emitCborUnmarshalStringField(w, subf)
if err != nil {
Expand Down