optimize anything using WriteString#85
Merged
whyrusleeping merged 2 commits intomasterfrom Aug 18, 2023
Merged
Conversation
Owner
Author
|
yeah i kinda didnt expect interface assertions to be expensive, but for 'map' style cbor objects youre writing a string every other field, and apparently the calls add up? |
Collaborator
|
Yeah, it's one of those "compile time" v. "run time" tradeoffs the go devs made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface type assertion of
io.WriteStringwas showing up pretty noticeably in some of my benchmarks, this makes that go away (almost) entirely. The benchmark in question went from around 3600ns/op to 3100ns/op.