Conversation
|
Do we need the version that supports the
|
|
(basically, I'd consider just sticking with newtypes to avoid the bikeshed) |
|
Would be nice to see tests with pre-recorded forms rather than just roundtrips. I'd come up with some but I'm only on my phone at the moment. If you |
I’d say yes, this is the only way that makes it possible to do things like set array size limits and nil slice handling, which will inevitably be useful |
|
Ah, good point. |
Stebalien
left a comment
There was a problem hiding this comment.
This looks correct. I'd much prefer to find a way to split this out into multiple functions as I think someone will trip over this eventually, but I'm not the one writing the code so I'm not sure how much work that would be.
This PR adds support for 'transparent' encoding, either in structs with
cborgen:"transparent"tag (which can be used with other tags), or by just defining a newtype that isn't a structOpinions this is based on: