turn max length consts into global vars#92
Merged
whyrusleeping merged 1 commit intomasterfrom Feb 1, 2024
Merged
Conversation
jazware
approved these changes
Feb 1, 2024
Owner
Author
|
steb im still eventually interested in getting a thumbs up from you but it seems low risk enough to merge this |
Collaborator
|
Can we make it an option during codegen instead? Maybe a new
Etc? Globals like this can make two different seemingly compatible libraries can't actually be used together. |
Collaborator
|
Hm. Even better: type Gen struct {
TupleEncoding []any
MapEncoding []any
PackageName string
MaxByteLength int // 0 for default
MaxArrayLength int // 0 for default
}
func (g *Gen) WriteTo(filename string) error {
// ...
}(or something like that) |
Owner
Author
|
Oh i like that appoach |
rvagg
added a commit
to filecoin-project/go-amt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to filecoin-project/go-hamt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to filecoin-project/go-hamt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to filecoin-project/go-amt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to filecoin-project/go-amt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to filecoin-project/go-hamt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to filecoin-project/go-hamt-ipld
that referenced
this pull request
Feb 6, 2024
rvagg
added a commit
to rvagg/cbor-gen
that referenced
this pull request
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you just want to set these globally