docs: test PR labels CI behavior#5
Closed
williamfzc wants to merge 21 commits into
Closed
Conversation
Replaced synthetic or open PR samples with actual merged/closed PRs from the repository to provide a more accurate reflection of the size label categorization. Added 4 samples each for sizes S, M, and L covering docs, fixes, ci, and features.
Based on user feedback, fine-grained domain labels (like `domain/base`) are too detailed for the early stages. This change adds support for applying `area/*` tags to indicate which important top-level modules a PR touches. Currently tracked areas: - `area/shortcuts` - `area/skills` - `area/cmd` Minor modules like docs, ci, and tests are intentionally excluded to keep tags focused on critical architectural components.
To avoid polluting the root `scripts/` directory, moved `sync_pr_labels.js` and `sync_pr_labels.samples.json` into a new `scripts/sync-pr-labels/` folder. Added a dedicated README to document its usage and behavior. Updated `.github/workflows/pr-labels.yml` to reflect the new path.
Renamed `scripts/sync-pr-labels/` to `scripts/pr-labels/` to keep directory names concise. Updated internal references and GitHub workflow files to point to the new path.
Added `expected_areas` lists to each sample in `samples.json` to reflect the newly added `area/*` high-level module tagging logic. Allows testing to accurately check both `size/*` and `area/*` outputs.
- Reorganized code into logical sections with clear comments - Encapsulated GitHub API interactions into a reusable `GitHubClient` class - Extracted and centralized classification logic into a pure `evaluateRules` function - Replaced magic numbers with named constants (`THRESHOLD_L`, `THRESHOLD_XL`) - Fixed `ROOT` path resolution logic - Simplified conditional statements and control flow
williamfzc
marked this pull request as ready for review
March 31, 2026 08:30
williamfzc
marked this pull request as draft
March 31, 2026 08:37
williamfzc
added
size/S
williamfzc
marked this pull request as ready for review
March 31, 2026 09:06
github-actions
Bot
added
the
size/S
williamfzc
marked this pull request as draft
March 31, 2026 09:40
github-actions
Bot
added
area/base
williamfzc
force-pushed
the
test-pr-pipeline
branch
3 times, most recently
from
March 31, 2026 14:28
9b50a0b to
88149c4
Compare
williamfzc
force-pushed
the
test-pr-pipeline
branch
from
April 1, 2026 02:26
88149c4 to
36b27a8
Compare
williamfzc
removed
size/M
williamfzc
force-pushed
the
test-pr-pipeline
branch
from
April 1, 2026 02:48
36b27a8 to
b409aa4
Compare
github-actions
Bot
added
domain/base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR to verify that the PR Labels GitHub Actions CI works successfully.