Parent: #277
Problem
Agents frequently violate commit message conventions: using process-oriented titles ("Address review findings"), including finding IDs (F1, W2), referencing automated tests, omitting backtick formatting for code identifiers, and not punctuating list items in the body. The existing git-commit-conventions skill is non-user-invocable and gets ignored by both the main agent and subagents.
Context
The git-commit-conventions skill at packages/agents/content/skills/git-commit-conventions/SKILL.md is listed as a skill dependency in the orchestrated-coder subagent. The reference data file _data/commit-format.md covers title format and length. Neither covers the body formatting rules that cause the most cleanup work.
Solution
Replace the git-commit-conventions skill directory with a commit skill directory. Make it user-invocable so it appears in the skill list and is more likely to be invoked. Expand the conventions to include all rules from the issue:
Title rules (existing + reinforced):
- 72 chars max (hard limit)
{workspace}|{work type}: {description} format
- No ticket ID
- Describes the code change, not the process
Body rules (new):
- Punctuate list items: each bulleted item ends with a period, comma, or semicolon.
- Break up large paragraphs; blank line between paragraphs.
- Use backticks for code identifiers (
methodName, MyClass, path/to/file).
- Never reference automated tests/CI (formatting, linting, unit tests, typechecking).
- Never use review finding IDs (F1, W2, T3, etc.) — these are meaningful only in review documents.
Skill references update:
- Update orchestrated-coder:
git-commit-conventions → commit in its skills list.
- Update
common-mistakes: cross-reference the new skill name.
- Update
_data/commit-format.md to include body formatting rules.
- Delete the
git-commit-conventions/ directory.
Acceptance criteria
Parent: #277
Problem
Agents frequently violate commit message conventions: using process-oriented titles ("Address review findings"), including finding IDs (F1, W2), referencing automated tests, omitting backtick formatting for code identifiers, and not punctuating list items in the body. The existing
git-commit-conventionsskill is non-user-invocable and gets ignored by both the main agent and subagents.Context
The
git-commit-conventionsskill atpackages/agents/content/skills/git-commit-conventions/SKILL.mdis listed as a skill dependency in the orchestrated-coder subagent. The reference data file_data/commit-format.mdcovers title format and length. Neither covers the body formatting rules that cause the most cleanup work.Solution
Replace the
git-commit-conventionsskill directory with acommitskill directory. Make it user-invocable so it appears in the skill list and is more likely to be invoked. Expand the conventions to include all rules from the issue:Title rules (existing + reinforced):
{workspace}|{work type}: {description}formatBody rules (new):
methodName,MyClass,path/to/file).Skill references update:
git-commit-conventions→commitin its skills list.common-mistakes: cross-reference the new skill name._data/commit-format.mdto include body formatting rules.git-commit-conventions/directory.Acceptance criteria
commitskill exists atpackages/agents/content/skills/commit/SKILL.mdwithuser-invocable: truegit-commit-conventions/directory is deletedgit-commit-conventionstocommitcommon-mistakescross-references updated_data/commit-format.mdupdated with body formatting rules